Skip to content

party_cloud functions#11

Open
Ilwyd wants to merge 23 commits into
doldecomp:mainfrom
Ilwyd:cloudResetAt
Open

party_cloud functions#11
Ilwyd wants to merge 23 commits into
doldecomp:mainfrom
Ilwyd:cloudResetAt

Conversation

@Ilwyd
Copy link
Copy Markdown
Contributor

@Ilwyd Ilwyd commented Jun 1, 2026

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Jun 1, 2026

Report for G8MJ01 (d0614d2 - dcaec22)

📈 Matched code: 10.72% (+0.03%, +952 bytes)

✅ 6 new matches
Unit Item Bytes Before After
MarioSt/party/party_cloud cloudGetBreathPower +368 0.00% 100.00%
MarioSt/party/party_cloud cloudResetAt +180 0.00% 100.00%
MarioSt/party/party_cloud cloudGetBreathDir +112 0.00% 100.00%
MarioSt/party/party_cloud cloudGetStatus +108 0.00% 100.00%
MarioSt/party/party_cloud cloudGetBreathDist +104 0.00% 100.00%
MarioSt/party/party_cloud mot_cloud +80 0.00% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
MarioSt/party/party_cloud .sdata2 +43 0.00% 31.82%
MarioSt/party/party_cloud .rodata +30 0.00% 54.55%

Comment thread include/party.h Outdated
@Ilwyd Ilwyd marked this pull request as draft June 1, 2026 13:56
@Ilwyd
Copy link
Copy Markdown
Contributor Author

Ilwyd commented Jun 2, 2026

Done with these for the moment

@Ilwyd Ilwyd marked this pull request as ready for review June 2, 2026 22:24
@Ilwyd Ilwyd changed the title [WIP] party_cloud functions party_cloud functions Jun 2, 2026
Comment thread include/mario/mario.h Outdated
Comment thread include/mario/mario.h Outdated
Comment thread include/party.h Outdated
Comment thread include/party.h Outdated
Comment thread src/mario/mario_cam.c
Comment thread src/party/party_cloud.c Outdated
Comment thread src/party/party_cloud.c Outdated
Comment thread src/party/party_cloud.c Outdated
Comment thread src/party/party_cloud.c
Comment on lines +165 to +166
// Might be beyond me at the moment
//
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth getting an m2c workflow set up since it gives you an alternate/usually more accurate view than Ghidra does, there's an online version at https://simonsoftware.se/other/m2c.html but you'll need a way to convert the asm into gcc annotation so it can parse it

Comment thread src/party/party_cloud.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants