MSound sound effect ids and bgm ids#110
Open
break-core wants to merge 7 commits into
Open
Conversation
Mrkol
requested changes
May 27, 2026
Mrkol
requested changes
May 27, 2026
| @@ -0,0 +1,51 @@ | |||
| // Exact order and names were pulled from mSound.asn | |||
Collaborator
There was a problem hiding this comment.
You need to add include guards to the new headers --
#ifndef MSOUND_BACKGROUND_MUSIC_HPP
#define MSOUND_BACKGROUND_MUSIC_HPP
... file
#endif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably one of the largest PRs I've done so far.
mSound.asn contains data that can be used to figure out BGM and sound effect IDs. What is stored for SE ids is a 28 byte name with 4 bytes reserved for the next sound's ID.
This replaces all known IDs for SE and BGM. (commits that are newer than when I wrote this or unmerged commits are not covered by this)