DrawBillboardStrategy improvements#137
Open
codewriter3000 wants to merge 6 commits into
Open
Conversation
codewriter3000
changed the title
Report for RSPE01_01 (167f5f6 - 6644d7a)📈 2 improvements in unmatched items
📉 2 regressions in unmatched items
|
kiwi515
requested changes
May 23, 2026
| f32 dx0 = sx * px; | ||
| f32 dy0 = sy * py; | ||
|
|
||
| float exp0 = px - dx0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| float exp0 = px - dx0; | |
| f32 exp0 = px - dx0; |
| f32 dy0 = sy * py; | ||
|
|
||
| float exp0 = px - dx0; | ||
| float exp1 = py - dy0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| float exp1 = py - dy0; | |
| f32 exp1 = py - dy0; |
| const EmitterDrawSetting& rSetting = | ||
| *pManager->mResource->GetEmitterDrawSetting(); | ||
|
|
||
| int flags = mNumTexmap != 0; |
Collaborator
There was a problem hiding this comment.
DrawNormalBillboard does mNumTexmap > 0 ? 1 : 0, does that work here too?
| pIt = pGetNextFunc(pManager, pIt)) { | ||
|
|
||
| if (pIt->GetLifeStatus() != 1) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
could we put the continue in brackets? just a style thing.
like this:
if (pIt->GetLifeStatus() != NW4R_EF_LS_ACTIVE) {
continue;
}|
|
||
| f32 sx = pIt->Draw_GetSizeX(); | ||
| if (sx < std::numeric_limits<f32>::epsilon()) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
if (sx < std::numeric_limits<f32>::epsilon()) {
continue;
}|
|
||
| f32 sy = pIt->Draw_GetSizeY(); | ||
| if (sy < std::numeric_limits<f32>::epsilon()) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
if (sy < std::numeric_limits<f32>::epsilon()) {
continue;
}|
|
||
| f32 dirScale = 1.0f; | ||
| if (rSetting.typeDir != 0) { | ||
| const math::VEC3& v0 = *reinterpret_cast<const math::VEC3*>( |
Collaborator
There was a problem hiding this comment.
pIt is a ef::Particle*, so this access is doing pIt->mParameter.mPosition.
some functions use GetParticleParameter() to access mParameter, and store that in a temp variable for re-use, so that may also help here.
| if (rSetting.typeDir != 0) { | ||
| const math::VEC3& v0 = *reinterpret_cast<const math::VEC3*>( | ||
| reinterpret_cast<const u8*>(pIt) + 0xAC); | ||
| const math::VEC3& v1 = *reinterpret_cast<const math::VEC3*>( |
Collaborator
There was a problem hiding this comment.
pIt is a ef::Particle*, so this access is doing pIt->mParameter.mPrevPosition.
| for (Particle* pIt = pGetFirstFunc(pManager); pIt != NULL; | ||
| pIt = pGetNextFunc(pManager, pIt)) { | ||
|
|
||
| if (pIt->GetLifeStatus() != 1) |
Collaborator
There was a problem hiding this comment.
the value 1 here is NW4R_EF_LS_ACTIVE
| } | ||
|
|
||
| f32 dirScale = 1.0f; | ||
| if (rSetting.typeDir != 0) { |
Collaborator
There was a problem hiding this comment.
0 is EmitterDrawSetting::AHEAD_BB_SPEED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made improvements to DrawBillboardStrategy methods.