Skip to content

kartCrash#40

Merged
SwareJonge merged 11 commits into
doldecomp:mainfrom
ThePlayerRolo:kartCrash
May 25, 2026
Merged

kartCrash#40
SwareJonge merged 11 commits into
doldecomp:mainfrom
ThePlayerRolo:kartCrash

Conversation

@ThePlayerRolo
Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented May 21, 2026

Report for MarioClub_us (4cf63d5 - edf712c)

📈 Matched code: 44.81% (+0.21%, +6820 bytes)

✅ 35 new matches
Unit Item Bytes Before After
main/Yamamoto/KartCrash KartCrash::DotornadeCrashCrl() +756 0.53% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeTornado() +472 0.84% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeSpin(ItemObj*) +413 0.96% 100.00%
main/Yamamoto/KartCrash KartCrash::DoMatchlessTimer() +409 0.97% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeBombCrash(ItemObj*) +400 0.99% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeHalfSpin(ItemObj*) +400 0.99% 100.00%
main/Yamamoto/KartCrash KartCrash::DoHalfSpinCrashCrl() +376 1.05% 100.00%
main/Yamamoto/KartCrash KartCrash::DoSpinCrashCrl() +368 1.08% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeFreezeCrash() +333 1.19% 100.00%
main/Yamamoto/KartCrash KartCrash::DoRollCrashCrl() +321 1.23% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeKameCrash(ItemObj*) +313 1.27% 100.00%
main/Yamamoto/KartCrash KartCrash::DoFreezeCrashCrl() +269 1.47% 100.00%
main/Yamamoto/KartCrash KartCrash::DoPitchCrashCrl() +241 1.64% 100.00%
main/Yamamoto/KartCrash KartCrash::SaveDir() +221 1.79% 100.00%
main/Yamamoto/KartCrash KartCrash::DoBombCrashCrl() +176 2.22% 100.00%
main/Yamamoto/KartCrash KartCrash::DoTornadeCenter() +173 2.27% 100.00%
main/Yamamoto/KartCrash KartCrash::DoDecBalloon() +117 3.33% 100.00%
main/Yamamoto/KartCrash KartCrash::MakeThunderSpin() +109 3.57% 100.00%
main/Yamamoto/KartCrash KartCrash::DoRabbitMark() +93 4.17% 100.00%
main/Yamamoto/KartCrash KartCrash::DoPointBomb(ItemObj*) +93 4.17% 100.00%
main/Yamamoto/KartCrash KartCrash::DoDecPointBomb() +89 4.35% 100.00%
main/Yamamoto/KartCrash KartCrash::NonRescue() +89 4.35% 100.00%
main/Yamamoto/KartCrash KartCrash::SetMatchlessTimer() +81 4.76% 100.00%
main/Yamamoto/KartCrash KartCrash::Init(int) +76 5.00% 100.00%
main/Yamamoto/KartCrash KartCrash::ClearMatchlessTimer() +65 5.88% 100.00%
main/Yamamoto/KartCrash ItemFireBall::IsEfctTypeRed() const +48 0.00% 100.00%
main/Yamamoto/KartCrash KartChecker::setBEHitBomb(ItemObj*) +40 0.00% 100.00%
main/Yamamoto/KartCrash KartChecker::setBEJugem() +40 0.00% 100.00%
main/Yamamoto/KartCrash CrsArea::searchInvValley(const JGeometry::TVec3<float>&) +40 0.00% 100.00%
main/Yamamoto/KartCrash KartDrawer::flashOn() +32 0.00% 100.00%

...and 5 more new matches

📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/Yamamoto/KartCrash KartCrash::MakeBurn(ItemObj*) +241 1.61% 99.03%
main/Yamamoto/KartCrash .sdata2 +156 0.00% 97.50%

@ThePlayerRolo ThePlayerRolo marked this pull request as ready for review May 24, 2026 20:08
@ThePlayerRolo
Copy link
Copy Markdown
Contributor Author

ready for review

1 similar comment
@ThePlayerRolo
Copy link
Copy Markdown
Contributor Author

ready for review

@SwareJonge
Copy link
Copy Markdown
Collaborator

LGTM, other than a few floating point numbers that could've been written shorter(eg 0.0099999999f = 0.01f)
But that's partially my fault for not having a contributors guide

@SwareJonge SwareJonge merged commit d387edc into doldecomp:main May 25, 2026
1 check passed
@ThePlayerRolo ThePlayerRolo deleted the kartCrash branch May 25, 2026 13:07
@ThePlayerRolo
Copy link
Copy Markdown
Contributor Author

LGTM, other than a few floating point numbers that could've been written shorter(eg 0.0099999999f = 0.01f) But that's partially my fault for not having a contributors guide

oh yeah that's true, mb I should've done that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants