Jj/sislib#2540
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merge the pointer-param inline into a single function so pos/result/remove_size stay in registers, and byte-index string_buffer (s16 signed for type 1, u16 unsigned for type 3). Remaining diffs are register swaps and an 8-byte frame. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fix halfword cursor reads (s16/u16 not byte/float), case 0/8 cursor reassign, pass cursor pointer to HSD_SisLib_803A7684, relocate block_33, while-loop the tail clear. Remaining diffs are the HSD_SisLib_8040CB00 SDA-vs-hoist register cascade and an add reassociation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Implement the ASCII->SIS conversion: fill in the space/dot/digit/colon kerning prefix blocks, the SJIS LUT lookup loop (lbl_8040C8C0 -> HSD_SisLib_8040C680), and convert to a for-loop. Remaining diffs are register allocation (has_kerning stack spill vs register, CTR loop) producing extra moves. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Implement the entry-replace function: find entry via fn_803A6FEC, format with vsnprintf+HSD_SisLib_803A67EC, grow/shrink the buffer and shift the tail, then copy the encoded string in. Remaining diffs are loop form (CTR vs manual decrement) and bulk-8 unroll style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fix the append-entry function: write through alloc->data_0 as the byte cursor (member reload/increment per write), use (s16)x/(s16)y for position, correct color/scale header order, and per-byte bulk copy. Remaining diffs are CTR loop form and register allocation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Implement the push-state function: 5-case switch (scale/color/scale2/align/value) that ensures string_buffer room (realloc + bulk copy + zero-fill) then writes the state bytes via x6C++. Remaining diffs are CTR loop form and post-increment register allocation in the copy loops. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the HSD_SisLib_803A8134 line-measure call in opcode 7, and fix the delay (case 5/6 u16) and scale (case 10 s16, case 14 u16) cursor reads to halfword. Remaining diffs are the HSD_SisLib_8040CD40/CB00 SDA-vs-hoist register cascade. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Report for GALE01 (06d20a7 - 1b1191b)📈 7 improvements in unmatched items
|
sadkellz
pushed a commit
to sadkellz/melee
that referenced
this pull request
Jun 6, 2026
* Match HSD_SisLib_803A594C (92%) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A5798 (99%) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A7F0C (98%) Merge the pointer-param inline into a single function so pos/result/remove_size stay in registers, and byte-index string_buffer (s16 signed for type 1, u16 unsigned for type 3). Remaining diffs are register swaps and an 8-byte frame. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A8134 (94%) Fix halfword cursor reads (s16/u16 not byte/float), case 0/8 cursor reassign, pass cursor pointer to HSD_SisLib_803A7684, relocate block_33, while-loop the tail clear. Remaining diffs are the HSD_SisLib_8040CB00 SDA-vs-hoist register cascade and an add reassociation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A67EC (60%) Implement the ASCII->SIS conversion: fill in the space/dot/digit/colon kerning prefix blocks, the SJIS LUT lookup loop (lbl_8040C8C0 -> HSD_SisLib_8040C680), and convert to a for-loop. Remaining diffs are register allocation (has_kerning stack spill vs register, CTR loop) producing extra moves. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A70A0 (79%) Implement the entry-replace function: find entry via fn_803A6FEC, format with vsnprintf+HSD_SisLib_803A67EC, grow/shrink the buffer and shift the tail, then copy the encoded string in. Remaining diffs are loop form (CTR vs manual decrement) and bulk-8 unroll style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A6B98 (87%) Fix the append-entry function: write through alloc->data_0 as the byte cursor (member reload/increment per write), use (s16)x/(s16)y for position, correct color/scale header order, and per-byte bulk copy. Remaining diffs are CTR loop form and register allocation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A7684 (55%) Implement the push-state function: 5-case switch (scale/color/scale2/align/value) that ensures string_buffer room (realloc + bulk copy + zero-fill) then writes the state bytes via x6C++. Remaining diffs are CTR loop form and post-increment register allocation in the copy loops. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Match HSD_SisLib_803A84BC (89%) Add the HSD_SisLib_803A8134 line-measure call in opcode 7, and fix the delay (case 5/6 u16) and scale (case 10 s16, case 14 u16) cursor reads to halfword. Remaining diffs are the HSD_SisLib_8040CD40/CB00 SDA-vs-hoist register cascade. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Remove target funcs --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: jellejurre <git@jellejurre.dev> Co-authored-by: JelleJurre <76777936+jellejurre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.