Jj/grbigblueroute 2#2532
Draft
jurrejelle wants to merge 11 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pool __FILE__ into the file string literal so asserts reference the shared grBb_Route_803E61D4 pool, fixing the data-offset mismatch across the unit's HSD_ASSERT calls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Use the bigblueroute2 struct view so the jobj caches and translation vectors use displacement addressing instead of cached pointers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Referencing 30/4000 as extern symbols left them out of the unit's .sdata2 literal pool, shifting every later constant. Emitting them as literals aligns the pool with the target and improves 8020DD64. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fix the route-entry angle randomization to use 5.2359877/2.6179938 instead of 2.0/1.0, which also corrects the unit's sdata2 pool order. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Implement the route state-machine update from scratch (was a stub): 4-state per-entry animation, spline positioning, jobj transforms and proximity sound/camera triggers. Include trigf.h so atan2f returns f32. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Express the early-out as !(x108 < limit) so the float compare emits bge instead of cror+beq, matching the target. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reload the RouteEntry base per field access (via macro) to match the target's addressing instead of caching the pointer in a saved register. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Report for GALE01 (66afaf4 - 58de0c5)📈 Matched code: 68.46% (+0.04%, +1524 bytes) ✅ 2 new matches
📈 7 improvements in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.