Merged
Conversation
C0114: Missing module docstring (missing-module-docstring) fixed by adding the docstring C0116: Missing function or method docstring fixed by adding the docstring to main() W1514: Using open without explicitly specifying an encoding fixed by specifying the manpage encoding as UTF-8 W1510: Using subprocess.run without explicitly set `check` fixed by adding check=True argument R1722: Consider using sys.exit() fixed by separating print from exit, and using sys.exit(1)
patricklodder
force-pushed
the
qa/fix-pylint-suggestions
branch
from
e45aedb to
f49897c
Compare
Member
Author
|
Rebased & ready for review. |
xanimo
previously approved these changes
Dec 4, 2021
Member
xanimo
left a comment
xanimo
left a comment
There was a problem hiding this comment.
ACK
pylint 1.14.5/bullseye/entrypoint.py
------------------------------------
Your code has been rated at 10.00/10
AbcSxyZ
previously approved these changes
Dec 4, 2021
Merged
Merged
Co-authored-by: AbcSxyZ <34010605+AbcSxyZ@users.noreply.github.com>
AbcSxyZ
approved these changes
Dec 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of having automated linters, I ran pylint manually to fix any existing issues, so that we have a clean starting slate once I PR linters. Some issues I originally worked on have already been solved with #26 so I am working on top of that and making that blocking for this PR.
Fixes:
entrypoint.pyfilemain()-> fixed by adding a docstring 🤓executable_options()-> fixed by specifying the manpage encoding as UTF-8check, increate_datadir()-> fixed by adding check=True argumentexecute()-> fixed by separating print from exit, and using sys.exit(1). Although this is just a recommendation, I think it's good to just follow the recommendations - saves time having to argue 😁