Skip to content

Fix continuous flow futex notification - #643

Open
jonasohland wants to merge 4 commits into
dmf-mxl:mainfrom
jonasohland:fix/cont-flow-notify
Open

Fix continuous flow futex notification#643
jonasohland wants to merge 4 commits into
dmf-mxl:mainfrom
jonasohland:fix/cont-flow-notify

Conversation

@jonasohland

Copy link
Copy Markdown
Contributor

Fixes #642

The issue can be reproduced by running the tests on commit 7cfaeb0 which is that adds a specific test for the bug without the fix. 5f8052b adds the fix.

jonasohland and others added 2 commits August 4, 2026 01:05
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com>
Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com>
Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
@jonasohland jonasohland self-assigned this Aug 3, 2026
@jonasohland jonasohland added the backport/v1.1 This PR should be back ported to the release branch of version 1.1. label Aug 3, 2026
@jonasohland jonasohland changed the title Fix/cont flow notify Fix continuous flow futex notification Aug 3, 2026

@lapointejp lapointejp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If @KimonHoffmann has some time to review his eyes would be relevant here I think.

Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com>
Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
@jonasohland
jonasohland force-pushed the fix/cont-flow-notify branch from 5a75874 to 3b044c7 Compare August 4, 2026 09:16

@KimonHoffmann KimonHoffmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this!
The only question I'd have is whether it is more correct to change signalCompletedBatch() to use flow->info.runtime.headIndex instead of _currentIndex instead?!

Comment thread lib/internal/src/PosixContinuousFlowWriter.cpp Outdated
@jonasohland

Copy link
Copy Markdown
Contributor Author

Thank you for finding and fixing this! The only question I'd have is whether it is more correct to change signalCompletedBatch() to use flow->info.runtime.headIndex instead of _currentIndex instead?!

Very reasonable. I will do that.

Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com>
Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
@jonasohland

Copy link
Copy Markdown
Contributor Author

@KimonHoffmann @pedro-alves-ferreira Changed it to use the head index from the flow data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.1 This PR should be back ported to the release branch of version 1.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Continuous flow writers are not notifying downstream reader correctly.

4 participants