Add algorithm header to ProviderConfig.cpp - #635
Merged
Conversation
no algorithm header will compile fail, std::ranges::find Signed-off-by: 曹勇 <1786386686@qq.com>
KimonHoffmann
approved these changes
Jul 29, 2026
KimonHoffmann
left a comment
KimonHoffmann
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thank you!
jonasohland
approved these changes
Jul 29, 2026
jonasohland
left a comment
jonasohland
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @saycmily can you tell me what system and compiler you are seeing this problem on?
Contributor
Author
ubuntu2204 x86_64, g++12.3, I use cmake preset Linux-GCC-Release |
Collaborator
|
Please address the reported clang-format errors. |
Signed-off-by: 曹勇 <1786386686@qq.com>
vt-tv
added
the
backport/v1.1
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no algorithm header will compile fail, std::ranges::find
Details
Backport requirements