Fix slice transfer for flows with alpha channel - #620
Merged
Conversation
jonasohland
requested review from
KimonHoffmann,
lapointejp,
mlefebvre1,
sviengkhou and
vt-tv
July 23, 2026 18:33
jonasohland
added
the
backport/v1.1
mlefebvre1
reviewed
Jul 24, 2026
mlefebvre1
left a comment
mlefebvre1
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just 2 questions.
k0zmo
reviewed
Jul 26, 2026
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com> Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com> Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com> Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
Co-authored-by: Jonas Ohland <jonas.ohland@gmail.com> Signed-off-by: Jonas Ohland (Riedel) <jonas.ohland@riedel.net>
jonasohland
force-pushed
the
feature/fabrics/sliced-alpha
branch
from
July 29, 2026 17:54
e16d6eb to
f1431e2
Compare
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the RMA based protocol (the only one we have) to correctly handle alpha channel when transferring slices.
Excluding the SHM provider from the tests for now, because the writer cannot handle multiple writes without completion queue reads in between. We intent to fix this later together with some other possible optimizations.
Fixes #592