Skip to content

Feature/a more resource hungry sink application - #502

Merged
vt-tv merged 10 commits into
dmf-mxl:mainfrom
sviengkhou:feature/a-more-resource-hungry-sink-application
Jul 29, 2026
Merged

Feature/a more resource hungry sink application#502
vt-tv merged 10 commits into
dmf-mxl:mainfrom
sviengkhou:feature/a-more-resource-hungry-sink-application

Conversation

@sviengkhou

@sviengkhou sviengkhou commented May 5, 2026

Copy link
Copy Markdown

A test app that consumed more resource was required for JT-DMF activity
Create a version of the GSTREAMER mxl-gst-sink application that can read from 4 source and create a mosaic.

Maybe this would benefit the MXL community.

garethsb
garethsb reviewed May 5, 2026
View reviewed changes
Comment thread tools/mxl-gst/sink.cpp
@garethsb

garethsb commented May 5, 2026

Copy link
Copy Markdown
Contributor

Maybe we could also use gst-mxl-rs to build a larger app with multiple video/audio/data flows, because that might be doable with a single gst-launch-1.0 command line!

@felixpou
felixpou requested a review from a team July 2, 2026 16:01
@felixpou

felixpou commented Jul 9, 2026 •
edited by sviengkhou
Loading

Copy link
Copy Markdown
Contributor

TSC

@sviengkhou
sviengkhou force-pushed the feature/a-more-resource-hungry-sink-application branch from 63c67ab to d0a321e Compare July 14, 2026 14:28
@sviengkhou

sviengkhou commented Jul 14, 2026

Copy link
Copy Markdown
Author

@vt-tv @felixpou just bumping this pr after rebase and update to address some issues..

@vt-tv

vt-tv commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@vt-tv @felixpou just bumping this pr after rebase and update to address some issues..
Thanks. could you resolve the open discussions/comments?

KimonHoffmann
KimonHoffmann requested changes Jul 16, 2026
View reviewed changes

@KimonHoffmann KimonHoffmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, a small MV is surely a good demo use-case!
A few small mostly stylistic suggestions from my side.

Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
KimonHoffmann
KimonHoffmann requested changes Jul 22, 2026
View reviewed changes

@KimonHoffmann KimonHoffmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the changes!
I resolved all the ones that have been taken care of and readied a few that got dropped due to the code having changed.

Comment thread tools/mxl-gst/sink.cpp Outdated
Comment thread tools/mxl-gst/sink.cpp Outdated
@sviengkhou

sviengkhou commented Jul 23, 2026

Copy link
Copy Markdown
Author

@KimonHoffmann Hopefully, I've not missed any of your comments. Thank you for the review.

KimonHoffmann
KimonHoffmann reviewed Jul 23, 2026
View reviewed changes

@KimonHoffmann KimonHoffmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
All changes have been addressed now, as far as I'm concerned. One last small comment about one of the changes, though.

Comment thread tools/mxl-gst/sink.cpp Outdated
@sviengkhou
sviengkhou force-pushed the feature/a-more-resource-hungry-sink-application branch 2 times, most recently from ae6d96f to 80bdc53 Compare July 24, 2026 14:25
@sviengkhou

sviengkhou commented Jul 27, 2026

Copy link
Copy Markdown
Author

@vt-tv @KimonHoffmann @felixpou a gentle nudge to get approval or review :)

@vt-tv

vt-tv commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@vt-tv @KimonHoffmann @felixpou a gentle nudge to get approval or review :)

can you resolve the conversation above with @KimonHoffmann ?

vt-tv
vt-tv approved these changes Jul 27, 2026
View reviewed changes

@vt-tv vt-tv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sviengkhou

sviengkhou commented Jul 27, 2026

Copy link
Copy Markdown
Author

@vt-tv @KimonHoffmann @felixpou a gentle nudge to get approval or review :)

can you resolve the conversation above with @KimonHoffmann ?

Done

@vt-tv

vt-tv commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@vt-tv @KimonHoffmann @felixpou a gentle nudge to get approval or review :)

can you resolve the conversation above with @KimonHoffmann ?

Done

Thanks. Waiting for @KimonHoffmann to adjust his review.

KimonHoffmann
KimonHoffmann approved these changes Jul 28, 2026
View reviewed changes

@KimonHoffmann KimonHoffmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Sithideth Viengkhou (Riedel) and others added 5 commits July 28, 2026 09:09
Sithideth Viengkhou (Riedel) @sviengkhou
(+) Multiview feature to gst-sink application
c6d4fd6 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
mv viewer.
c84c4d1 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
@mlefebvre1 @sviengkhou
fix move semantics for MxlReader
cae5efe 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Michael Lefebvre <michael.lefebvre@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
fixed layout
c71099d 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
Fix memory leaks in mxl-gst sink
e1ffbe4 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) added 5 commits July 28, 2026 09:09
Sithideth Viengkhou (Riedel) @sviengkhou
more static memory protection
1864304 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
+ license file for flow
15ad2fe 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
addressed Kimon's comments
ec1b2ff 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
addressing more of Kimon's comments
de8c437 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sithideth Viengkhou (Riedel) @sviengkhou
more fix, after review
c6ff199 
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
@sviengkhou
sviengkhou force-pushed the feature/a-more-resource-hungry-sink-application branch from 80bdc53 to c6ff199 Compare July 28, 2026 13:09
@vt-tv
vt-tv merged commit 1fed092 into dmf-mxl:main Jul 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garethsb garethsb garethsb left review comments
@KimonHoffmann KimonHoffmann KimonHoffmann approved these changes
@vt-tv vt-tv vt-tv approved these changes
@mlefebvre1 mlefebvre1 Awaiting requested review from mlefebvre1
@felixpou felixpou Awaiting requested review from felixpou
@jonasohland jonasohland Awaiting requested review from jonasohland

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sviengkhou @garethsb @felixpou @vt-tv @KimonHoffmann @mlefebvre1