Conversation
jakeyr
commented
Dec 14, 2012
- add Gzip class for compression of strings and inputstreams
- modify controller to use gzip when accept-encoding header requests it
- add new gzipEnabled configuration setting to enable gzip (default off)
- add Gzip class for compression of strings and inputstreams - modify controller to use gzip when accept-encoding header requests it
|
Hey, thanks for taking the time to add Gzip support, and share it with the community, that's great. |
|
Yes, agreed that in most cases doing a CPU-intensive job like compression is a better job for the web server or even the LB or reverse proxy, but given that your efforts to get the core to support this at the netty level have been met with lukewarm responses, i figured we could do it here. this spot, imo, is a good place to add gzip because when combined with a CDN using your web server as origin and the press module, you have a simple instant cached/gziped/edge-served solution. i would not recommend anyone not serving press content via a CDN turn this on, given that it's happening on every request. i'll explain as much in the doc modifications you asked for. |