Skip to content

[fix][dingo-exec] Adjusting varbinary to blob #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guojn1 wants to merge 1 commit into
base: quickBI-v3.0.0
Choose a base branch
from
Open

[fix][dingo-exec] Adjusting varbinary to blob #1837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dingo-calcite/src/main/java/io/dingodb/calcite/executor/ShowColumnsExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ private List<List<String>> getColumnFields() {
if (column.getPrecision() > 0 && column.getScale() >= 0) {
type = type + "(" + column.getPrecision() + "," + column.getScale() + ")";
}
} else if ("varbinary".equalsIgnoreCase(type)) {
type = "blob";
}
columnValues.add(type.toLowerCase());
columnValues.add(column.isNullable() ? "YES" : "NO");
Expand Down
2 changes: 2 additions & 0 deletions dingo-calcite/src/main/java/io/dingodb/calcite/executor/ShowCreateTableExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ private static String getTypeName(String typeName, String elementTypeName) {
elementTypeName = "INT";
}
return elementTypeName + " " + typeName;
case "VARBINARY":
return "blob";
default:
return typeName;
}
Expand Down
15 changes: 12 additions & 3 deletions dingo-exec/src/main/java/io/dingodb/exec/operator/InfoSchemaScanOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,15 @@ private static Iterator<Object[]> getInformationColumns(String user, String host
type = "blob";
}
type = type.toLowerCase();
long precision = column.precision;
Long octetLength = null;
String dataType = column.getSqlTypeName();
if ("varbinary".equalsIgnoreCase(dataType)) {
dataType = "blob";
precision = 65535;
octetLength = 65535L;
}

colRes.add(new Object[]{
"def",
schemaTables.getSchemaInfo().getName(),
Expand All @@ -187,9 +196,9 @@ private static Iterator<Object[]> getInformationColumns(String user, String host
// is null
column.isNullable() ? "YES" : "NO",
// type name
column.getSqlTypeName(),
(long) column.precision,
null,
dataType,
precision,
octetLength,
null,
null,
null,
Expand Down
Loading