Fix SwiftLint violations: trailing whitespace, identifier names, and closure syntax#2
Open
dillonvargo wants to merge 1 commit into
Open
Fix SwiftLint violations: trailing whitespace, identifier names, and closure syntax#2dillonvargo wants to merge 1 commit into
dillonvargo wants to merge 1 commit into
Conversation
…closure syntax
- Auto-fix 600+ trailing whitespace violations
- Rename short identifiers: 'i' -> 'index'/'dayOffset', 'vm' -> 'viewModel', 'to' -> 'targetUnit'
- Rename 'UI' enum to 'UserInterface' to meet minimum length requirement
- Convert Button(action:) to Button { } label: { } syntax to fix multiple_closures violations
- Update all references to AppConstants.UI to AppConstants.UserInterface
Remaining 16 warnings are style issues requiring significant refactoring:
- File/type body length violations (would require splitting files)
- Function parameter count (would require API changes)
- Line length violations (would require reformatting)
- Cyclomatic complexity (would require logic restructuring)
Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses SwiftLint violations, reducing the count from 637 violations to 16 warnings and 1 error. The remaining issues are style warnings that would require significant refactoring (file length, function parameter count, etc.).
Changes made:
i→index/dayOffset,vm→viewModel,to→targetUnit/sourceUnitAppConstants.UIenum toAppConstants.UserInterface(minimum 3-character type name requirement)Button(action:) { }toButton { } label: { }syntax to fix multiple_closures_with_trailing_closure violationsReview & Testing Checklist for Human
AppConstants.UserInterfacereferences - All usages of the renamed enum were updated, but confirm no build errors related to this renameTest Plan
Notes
Remaining violations (not addressed):
DietViewModel.swiftandDietTrackingView.swift(would require splitting files)NutritionInfo.swift(would require logic restructuring)Requested by: Dillon Vargo (@dillonvargo)
Link to Devin run: https://app.devin.ai/sessions/99e0f6749f2243e9ae459218d9dd7fb5