bugfix: Ignore paths filtering with file outside of paths#14
Open
bugfix: Ignore paths filtering with file outside of paths#14
Conversation
… the other does not When paths and ignore_paths are both defined, and the pull request contains one file in the ignored path and another outside of paths and outside ignore_paths, a new resource version is created because the number of files matching ignore_paths does not match the number of files changed. This behaviour is incorrect because there may be changed files that do not match paths and do not match ignore_paths.
denniskpw
force-pushed
the
bugfix/paths_ignore_paths_filtering
branch
from
b16034a to
cce6c13
Compare
christophermancini
suggested changes
Feb 1, 2021
christophermancini
left a comment
christophermancini
left a comment
There was a problem hiding this comment.
Only reviewing this to get it off my list of review requested PRs. I am no longer involved in this project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
pathsis defined andignore_pathsis has the coverage of one more subdirectory ofpaths, there can be a scenario where a pull request contains 2 files. The first file exists withinignore_pathsand the second file does not matchpathsnorignore_paths. The expectation is no new resource version should be created, but since we match on the number of files in the pull request with the number of files matched by the ignore path (in our example 2 and 1 respectively), because2 != 1, the earlier logic to ignore the pull request would not have been satisfied (hencecontinuewould not have been executed). Instead, we must also check that there are no files that exist after applying bothpathsandignore_pathsfilter.