ci(release): make stable releases composable - #3473
Open
benjaminshafii wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| - name: Mint release App tag-only token | ||
| id: release-app-tag | ||
| uses: actions/create-github-app-token@v2 |
Contributor
There was a problem hiding this comment.
Pin the release App token action to an immutable commit
The newly added privileged token-minting action uses the mutable @v2 tag, allowing a future action-tag compromise to execute code with the release App private key and contents-write token.
Evidence
- The continuation workflow executes
actions/create-github-app-token@v2withRELEASE_APP_PRIVATE_KEYat lines 200-203. - The resulting token is used to push the release tag with contents write permission at lines 211 and 237.
- Because
@v2is mutable remote code, a compromised tag could exfiltrate the private key or mint/use the release token to modify repository contents. - Pin the action to a reviewed full commit SHA, optionally retaining the version in a comment.
Also found at 1 additional location
.github/workflows/release-prepare.yml:65-65
Identified by Warden · diff-security-review · UUE-7YX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm release:test(21 passed)pnpm release:review(passed)pnpm release:prepare -- patch --dry-run(passed)rhysd/actionlintDocker image (passed; known custom Blacksmith label suppressed)koalaman/shellcheckDocker image (passed)git diff --check(passed)Required setup before first release
RELEASE_APP_ID,RELEASE_APP_PRIVATE_KEY, and exactRELEASE_APP_LOGINv*tag-creation ruleset; do not grant adevbranch bypassRuntime evidence
Incomplete until the dedicated Release App and tag ruleset are configured. Unit and workflow-contract assertions cover planning, signed metadata, exact-attempt 18-stage artifacts, immutable publication, npm idempotency, and AUR consistency; no deterministic testkit witness can execute GitHub protected-branch/App installation semantics or external publishers locally.