[3DS] Update text input state using data from the on-screen keyboard - #8663
Merged
Conversation
glebm
enabled auto-merge (rebase)
August 9, 2026 09:13
glebm
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue on 3DS where it was impossible to proceed through any menu where the initial value is empty and empty values are not allowed.
Because the 3DS uses SDL1, it is unable to update text input state via
SDL_EVENT_TEXT_INPUTevents. Instead, it was updating the underlying char array, which appears to work because it gets properly rendered on-screen. But theTextInputStateobject also tracks the length of the user input, which wasn't getting updated properly so the length of the initial value was used for validation instead of the length of the user input.Instead of updating the underlying char array directly, this PR uses a callback to update text input state via the
TextInputState::assign()function.