Skip to content

UI: Refactor gameplay settings section headers - #8635

Closed
thiagomucci wants to merge 2 commits into
diasurgical:masterfrom
thiagomucci:feature/gameplay-settings-sections
Closed

UI: Refactor gameplay settings section headers#8635
thiagomucci wants to merge 2 commits into
diasurgical:masterfrom
thiagomucci:feature/gameplay-settings-sections

Conversation

@thiagomucci

Copy link
Copy Markdown

Refactored `settingsmenu.cpp` to streamline the Gameplay settings sections based on review feedback.

Changes:

  • Renamed 'Items & Auto Pickup' header to 'Inventory Management'
  • Removed 'Safety & Focus' header (items fall under Game Rules / Controls)

Closes #8508

Add section headers to Gameplay settings

Add lightweight, non-selectable section headers and spacers to the
Gameplay settings menu so related options are easier to scan.

Keep the change UI-only by injecting disabled list rows while building
the settings list, without changing the options model or option behavior.

Also make the initial focus fall back to the first selectable option if
the previously selected option is no longer visible.
@Trihedraf

Copy link
Copy Markdown
Collaborator

This is a duplicate of another open pr #8513 with 1 small change with no explanation of why.

@thiagomucci

Copy link
Copy Markdown
Author

I noticed PR #8513 has been stale for a while and hadn't been updated with the maintainer's review feedback.
I opened this PR to apply those exact requested changes:
Renamed 'Items & Auto Pickup' to 'Inventory Management' to make the section name clearer.
Removed the 'Safety & Focus' header so options like crippling shrines and mouse settings group naturally under Game Rules and Controls without creating redundant categories.
The goal was simply to address the previous review feedback and get this UI cleanup ready to merge.

@thiagomucci
thiagomucci force-pushed the feature/gameplay-settings-sections branch from ee38dee to 4eca23e Compare July 23, 2026 18:20
@thiagomucci
thiagomucci marked this pull request as draft August 7, 2026 14:41
@thiagomucci thiagomucci closed this by deleting the head repository Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group related Gameplay settings with labels/separators for readability

3 participants