Replace tl::expected with std::expected#8615
Closed
glebm wants to merge 4 commits into
Closed
Conversation
glebm
force-pushed
the
std-expected
branch
5 times, most recently
from
July 13, 2026 09:08
a5a5534 to
c8d95fa
Compare
This was referenced Jul 13, 2026
Now that the project targets C++23, use the standard library's std::expected instead of the vendored tl::expected polyfill: - tl::expected -> std::expected, tl::unexpected/tl::make_unexpected -> std::unexpected - .map()/.map_error() -> .transform()/.transform_error() - #include <expected.hpp> -> #include <expected>, grouped with std headers - Remove 3rdParty/tl/expected.hpp (the tl target remains for function_ref.hpp) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Only PS4 and Xbox nxdk are failing. These toolchains haven't updated their libcxx in many years. I think we should disable CI for these platforms until the toolchains are updated, otherwise we'll be stuck on old language level for who knows how long. Tracking bugs for libcxx update:
Failing builds: |
These toolchains haven't updated their libcxx in years. Disables these CI builds in order to avoid being stuck on old language level support. Once / if the toolchains are updated, we can re-enable these platforms. Toolchain update bugs: * PS4: OpenOrbis/OpenOrbis-PS4-Toolchain#262 * Xbox nxdk: XboxDev/nxdk-libcxx#3
glebm
marked this pull request as ready for review
July 13, 2026 10:27
glebm
enabled auto-merge (rebase)
July 13, 2026 10:27
Collaborator
Author
|
To avoid rebasing 3 PRs every time, I'm consolidating this PR into the std-format one. |
auto-merge was automatically disabled
July 19, 2026 12:21
Pull request was closed
Member
|
That's also kind of why I was reviewing that one first :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the project targets C++23, use the standard library's std::expected instead of the vendored tl::expected polyfill: