Untangle more dependencies#8570
Open
glebm wants to merge 1 commit into
Open
Conversation
glebm
enabled auto-merge (rebase)
May 25, 2026 02:31
glebm
marked this pull request as draft
May 25, 2026 02:46
auto-merge was automatically disabled
May 25, 2026 02:46
Pull request was converted to draft
glebm
force-pushed
the
dun-render-standalone
branch
from
May 26, 2026 03:41
d712aac to
f475348
Compare
glebm
changed the title
glebm
force-pushed
the
dun-render-standalone
branch
from
May 26, 2026 04:19
f475348 to
a4a9026
Compare
glebm
marked this pull request as ready for review
May 26, 2026 04:21
glebm
enabled auto-merge (rebase)
May 26, 2026 04:21
glebm
force-pushed
the
dun-render-standalone
branch
2 times, most recently
from
May 26, 2026 15:34
06e0d91 to
866f50d
Compare
glebm
force-pushed
the
dun-render-standalone
branch
from
June 10, 2026 22:40
866f50d to
9f5b0d6
Compare
glebm
force-pushed
the
dun-render-standalone
branch
from
July 4, 2026 08:48
9f5b0d6 to
792ee0c
Compare
Collaborator
Author
|
Rebased |
Split several monolithic files to reduce transitive dependencies and
enable the dun_render_benchmark to link without bringing in all of
DevilutionX:
- Extract dungeon tile globals and loading functions from `gendung` into
`dun_tile_data.{hpp,cpp}`
- Extract light table data and MakeLightTable from lighting into
`engine/light_tables.{hpp,cpp}`
- Move cursor_id and SelectionRegion to cursor_defs.hpp
- Extract quest log rendering to `panels/quest_log.{hpp,cpp}`
- Extract drlg quest setpiece logic to `levels/drlg_quests.{hpp,cpp}`
- Extract quest data loading to `tables/questdat.{hpp,cpp}`
- Move `GameData` and `gbIsMultiplayer` into `game_mode.{hpp,cpp}`
- Add `parse_sfx_id.{hpp,cpp}`
- Update CMake libraries accordingly
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
glebm
force-pushed
the
dun-render-standalone
branch
from
July 16, 2026 04:18
792ee0c to
466b7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split several monolithic files to reduce transitive dependencies and enable the dun_render_benchmark to link without bringing in all of DevilutionX:
gendungintodun_tile_data.{hpp,cpp}engine/light_tables.{hpp,cpp}panels/quest_log.{hpp,cpp}levels/drlg_quests.{hpp,cpp}tables/questdat.{hpp,cpp}GameDataandgbIsMultiplayerintogame_mode.{hpp,cpp}parse_sfx_id.{hpp,cpp}