Implement device reconnection and error deduplication#11
Open
vijayvuyyuru wants to merge 2 commits intodh1tw:masterfrom
Open
Implement device reconnection and error deduplication#11vijayvuyyuru wants to merge 2 commits intodh1tw:masterfrom
vijayvuyyuru wants to merge 2 commits intodh1tw:masterfrom
Conversation
Author
|
Hey @dh1tw — just wanted to bump this in case it got lost in the shuffle. Happy to address any feedback or make changes if needed. Thanks for your time and for maintaining this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements attempting to reconnect to a device on read error and deduplicating error logs spam that can occur from USB read errors.