Skip to content

fix(ratel): correct Ingress rule host placement and example values #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaelapteanu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ratel): correct Ingress rule host placement and example values #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df2e36
fix(ratel): place ingress rule host beside http, not under it
nicolaelapteanu Apr 20, 2026
a192f57
fix: remove host from no-host example
nicolaelapteanu Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/ratel/example_values/ingress/ingress-alb-no_host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# aws-load-balancer-controller
# * https://github.com/kubernetes-sigs/aws-load-balancer-controller
# NOTE:
# * shared ALB with group name of 'dgraph' will be used.
# NOTE:
# * shared ALB with group name of 'dgraph' will be used.
# This avoids provisioning multiple ALBs
ingress:
enabled: true
className: alb
annotations:
Expand All @@ -13,4 +14,3 @@
- paths:
- path: /*
pathType: ImplementationSpecific
host: ratel.example.com
7 changes: 4 additions & 3 deletions charts/ratel/example_values/ingress/ingress-alb-with_host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ingress:
alb.ingress.kubernetes.io/scheme: internet-facing
alb.ingress.kubernetes.io/target-type: ip
hosts:
- paths:
- path: /*
pathType: ImplementationSpecific
- host: ratel.example.com
paths:
- path: /
pathType: Prefix
8 changes: 5 additions & 3 deletions charts/ratel/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ spec:
{{- end }}
rules:
{{- range .Values.ingress.hosts }}
{{- if .host }}
- host: {{ .host | quote }}
http:
{{- else }}
- http:
{{- end }}
paths:
{{- range .paths }}
- path: {{ .path }}
Expand All @@ -57,8 +62,5 @@ spec:
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
{{- if .host }}
host: {{ .host | quote }}
{{- end }}
{{- end }}
{{- end }}