Conversation
| if ($this->errors) { | ||
| throw new Exception('SQL translate error: ' . trim(reset($this->errors), '*'), 0, $sql); | ||
| if ($this->errors !== []) { | ||
| throw new Exception('SQL translate error: ' . trim((string) reset($this->errors), '*'), 0, $sql); |
There was a problem hiding this comment.
it changes behavior, can be null or empty array. And original code is correct.
There was a problem hiding this comment.
I reverted original condition but kept (string) for PhpStan because function reset() can return mixed value.
There was a problem hiding this comment.
For nonempty string[]? I think it must be always string.
| if (in_array($code, [1216, 1217, 1451, 1452, 1701], true)) { | ||
| return new Dibi\ForeignKeyConstraintViolationException($message, $code, $sql); | ||
| if (is_int($code) === true) { | ||
| if (in_array($code, [1216, 1217, 1451, 1452, 1701], true)) { |
There was a problem hiding this comment.
there is no reason for this change, in_array checks type
There was a problem hiding this comment.
Parameter $code can be int or string. In the case of string the if statements can be skipped (better performance and code readability).
What do you think?
There was a problem hiding this comment.
I think in mysql driver it is always int.
| { | ||
| if ($this->autoFree && $this->getResultResource()) { | ||
| if ($this->autoFree) { | ||
| $this->getResultResource(); |
There was a problem hiding this comment.
I tested all combinations and I think not. The result of getResultResource() is always true, so it should be called in if statement.
dg
force-pushed
the
master
branch
8 times, most recently
from
138139d to
81a66da
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
8db0534 to
cc3b09e
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
45c0839 to
8881eb1
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
0bdf956 to
96da320
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
cefe754 to
ca42569
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3a61c9e to
b47c9cc
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
d77bdd6 to
1585255
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
16765c4 to
cab1c5b
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
0ee3834 to
fafa6cb
Compare
2 participants
I fixed some PhpStan errors.
Resend #363.