Skip to content

feat: Length of wait for ingress status configurable. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondk merged 9 commits into from
Jan 21, 2026
Merged

feat: Length of wait for ingress status configurable. #227

raymondk merged 9 commits into from
Jan 21, 2026

Conversation

@m-styp
Copy link
Contributor

@m-styp m-styp commented Jan 19, 2026

Made AwaitIngressStatusRounds configurable.

@m-styp m-styp requested a review from a team as a code owner January 19, 2026 20:47
raymondk
raymondk reviewed Jan 20, 2026
View reviewed changes
peterpeterparker
peterpeterparker reviewed Jan 20, 2026
View reviewed changes
@peterpeterparker
Copy link
Member

peterpeterparker commented Jan 20, 2026 •
edited
Loading

I added few questions but, @raymondk question is the first to answer - i.e. if ultimately the PR is not required, my comments can be ignored 😉

Aside from that, should tests be provided as well?

@raymondk raymondk changed the title Made AwaitIngressStatusRounds configurable. feat: Made AwaitIngressStatusRounds configurable. Jan 20, 2026
peterpeterparker
peterpeterparker approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

I let @raymondk handles it from here

Notes:

  1. It has to be released as breaking change
  2. It's not clear for me what is the testing policy in this repo, maybe there are ways to provide tests for those PRs that have been passed recently
  3. It seems the CI is flaky

@raymondk raymondk changed the title feat: Made AwaitIngressStatusRounds configurable. feat: Length of wait for ingress status configurable. Jan 21, 2026
@raymondk raymondk enabled auto-merge January 21, 2026 02:09
@raymondk
Copy link
Contributor

raymondk commented Jan 21, 2026 •
edited
Loading

Would have been good to update the CHANGELOG here but I'll do it with the release. nevermind that part is automated.
Also sucks that we're reverting the previous change and breaking the interface - which forces a new major version.... 🤷

@raymondk raymondk added this pull request to the merge queue Jan 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2026
@raymondk raymondk added this pull request to the merge queue Jan 21, 2026
Merged via the queue into dfinity:main with commit 05a6e66 Jan 21, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondk raymondk raymondk approved these changes

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees

No one assigned

Labels

external-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-styp @peterpeterparker @raymondk