Skip to content

feat: login twitter test#187

Draft
juliaam wants to merge 11 commits into
mainfrom
issue-183
Draft

feat: login twitter test#187
juliaam wants to merge 11 commits into
mainfrom
issue-183

Conversation

@juliaam

@juliaam juliaam commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Closes #183

Feature

Criação do teste para o login do twitter

Visual evidences 🖼️

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created

@juliaam juliaam requested review from a team as code owners September 4, 2024 21:11
@juliaam juliaam requested review from DominMFD, Frompaje, JpBurgarelli, Luiginicoletti and PiluVitu and removed request for a team September 4, 2024 21:11
@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 88.44% (🎯 85%) 291 / 329
🟢 Statements 88.51% (🎯 85%) 293 / 331
🟢 Functions 86.23% (🎯 85%) 94 / 109
🔴 Branches 81.48% (🎯 85%) 44 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/middlewares/auth/auth-jwt.ts 100% 100% 100% 100%
Generated in workflow #343

@DominMFD DominMFD self-assigned this Sep 5, 2024
Comment thread src/features/twitter/controllers/twitter-controller.test.ts Outdated
Comment thread src/features/twitter/controllers/twitter-controller.test.ts Outdated

@Frompaje Frompaje left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem que padronizar esse arquivo todo pra ficar igual os teste da pr #174

@DominMFD DominMFD assigned juliaam and unassigned DominMFD Sep 9, 2024
DominMFD
DominMFD previously approved these changes Sep 9, 2024
@DominMFD

DominMFD commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Amiga, tira um print da UI de teste mostrando os coverage

Luiginicoletti
Luiginicoletti previously approved these changes Sep 10, 2024

@Luiginicoletti Luiginicoletti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amassou como sempre xu!

gif-by-late-night-with-seth-meyers

Comment thread src/features/twitter/services/twitter-service.test.ts
Comment thread src/features/twitter/controllers/twitter-controller.test.ts
@c4mpus

c4mpus commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

esses testes não deveriam ser feitos depois da refatoração no controller e service do twitter?

@Frompaje Frompaje self-requested a review September 12, 2024 16:46
Comment thread src/features/twitter/controllers/twitter-controller.test.ts

vi.spyOn(jwt, 'verify').mockReturnValue(mockPayload as any);

authController.login(req, res, next);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq ta sem await?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq nao precisa

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mas nao sei se é melhor com ou sem btw

@juliaam juliaam marked this pull request as draft September 20, 2024 16:15
@juliaam juliaam dismissed stale reviews from Luiginicoletti and DominMFD via 444cec0 September 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] Criar Teste para Componentes de Autenticação

5 participants