Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/dependabot/update_metadata.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,31 @@ updated-dependencies:
expect(updatedDependencies[1].newVersion).toEqual('1.27.1')
})

test('it handles Docker digest-only updates without classifying the tag as changed', async () => {
const commitMessage = `Bumps the docker group with 1 update: shawntoffel/dependabot-digest-test.


Updates \`shawntoffel/dependabot-digest-test\` from \`e1b523f\` to \`5fdf1f3\`

---
updated-dependencies:
- dependency-name: shawntoffel/dependabot-digest-test
dependency-version: 1.0-alpine3.24
dependency-type: direct:production
dependency-group: docker
...

Signed-off-by: dependabot[bot] <support@github.com>
`
const updatedDependencies = await updateMetadata.parse(commitMessage, '', 'dependabot/docker/docker-2b208d09c0', 'master')

expect(updatedDependencies).toHaveLength(1)
expect(updatedDependencies[0].dependencyName).toEqual('shawntoffel/dependabot-digest-test')
expect(updatedDependencies[0].updateType).toEqual('')
expect(updatedDependencies[0].prevVersion).toEqual('1.0-alpine3.24')
expect(updatedDependencies[0].newVersion).toEqual('1.0-alpine3.24')
})

test('it handles new versions from YAML', async () => {
const commitMessage = `Bump the non-breaking group in /log4j-parent with 2 updates

Expand Down
15 changes: 13 additions & 2 deletions src/dependabot/update_metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,15 @@ export async function parse (commitMessage: string, body: string, branchName: st
nameCounters.set(dependencyName, nameIndex + 1)
const updatedVersionList = updatedVersions.get(dependencyName)
const updatedVersion = updatedVersionList?.[nameIndex]
const lastVersion = updatedVersion?.prevVersion || (index === 0 ? prev : '')
const nextVersion = dependency['dependency-version'] || updatedVersion?.newVersion || (index === 0 ? next : '')
const dependencyVersion = dependency['dependency-version']
// Digest-only Docker updates code-format the digests while dependency-version contains the unchanged tag.
const isDockerDigestOnlyUpdate = chunks[1] === 'docker' &&
!!dependencyVersion &&
!dependency['update-type'] &&
isMarkdownCodeSpan(updatedVersion?.prevVersion) &&
isMarkdownCodeSpan(updatedVersion?.newVersion)
const lastVersion = isDockerDigestOnlyUpdate ? dependencyVersion : updatedVersion?.prevVersion || (index === 0 ? prev : '')
const nextVersion = dependencyVersion || updatedVersion?.newVersion || (index === 0 ? next : '')
const updateType = dependency['update-type'] || calculateUpdateType(lastVersion, nextVersion)
return {
dependencyName: dependency['dependency-name'],
Expand Down Expand Up @@ -156,6 +163,10 @@ function parseMetadataLinks(commitMessage: string): Map<string, dependencyVersio
return updates
}

function isMarkdownCodeSpan (value?: string): boolean {
return !!value && value.startsWith('`') && value.endsWith('`')
}

export function calculateUpdateType (lastVersion: string, nextVersion: string) {
if (!lastVersion || !nextVersion || lastVersion === nextVersion) {
return ''
Expand Down
Loading