-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add support for API 2.0 in Mimecast Event Collector #42498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||
🤖 Content-bot Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
content-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Thanks for the update to the Mimecast pack. I've reviewed the changes and have a few points to discuss, primarily regarding the proxy implementation and test mocking.
Please ensure proxy arguments are passed correctly to the request methods rather than the aiohttp session, and update the unit tests to use AsyncMock for asynchronous methods. It would also be helpful to clarify the API 2.0 credential steps in the documentation and consolidate the breaking changes in the release notes.
Great work so far
@richardbluestone, @JasBeilin please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.py
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.py
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.py
Show resolved
Hide resolved
@julieschwartz18 Can you do this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamalq97 Doc review complete. Please confirm the suggested edits and regenerate the integration README from the YAML file. In the meantime, adding the label docs-approved.
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Mimecast/Integrations/MimecastEventCollector/MimecastEventCollector.yml
Outdated
Show resolved
Hide resolved
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
Related Issues
fixes: CIAC-14914
Description
Add support for Mimecast API 2.0 and implement async event fetching logic.
Version release notes: