Skip to content

Conversation

@kamalq97
Copy link
Contributor

@kamalq97 kamalq97 commented Jan 1, 2026

Related Issues

fixes: CIAC-14914

Description

Add support for Mimecast API 2.0 and implement async event fetching logic.

Version release notes:

  • Breaking Change: Migrated from the legacy API 1.0 authentication method to OAuth2 client credentials flow for Mimecast API 2.0 following the announcement about Mimecast API 1.0 End of Life.

    • Added support for new API 2.0 authentication using Client ID and Client Secret parameters.
    • Deprecated support for API 1.0 authentication and removed the Application ID, Application Key, Access Key, and Secret Key parameters.
  • Breaking Change: Restricted the First fetch timestamp parameter to audit events due to SIEM API endpoint limitations.

  • Added support for the Fetch event types parameter which specifies the types of events to fetch.

  • Added support for the event_types, start_date, and end_date arguments in the mimecast-get-events command.

  • Updated the Docker image to: demisto/py3-tools:1.0.0.6308650.

@kamalq97 kamalq97 self-assigned this Jan 1, 2026
@kamalq97 kamalq97 requested a review from JasBeilin January 1, 2026 08:56
@kamalq97 kamalq97 added enhancement inprogress It means the PR is still on progress, and should not be merged even if the build is green or approve python Pull requests that update Python code labels Jan 1, 2026
@kamalq97 kamalq97 marked this pull request as draft January 1, 2026 08:57
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Mimecast/Integrations/MimecastEventCollector
   MimecastEventCollector.py4176684%126–127, 147, 163–164, 173, 252–253, 256–258, 260–263, 266–270, 274–275, 279, 283, 286, 357, 433, 437–438, 533, 607, 622, 626, 700–701, 785–790, 794–796, 798, 807–809, 812–813, 816–817, 819, 823, 899–900, 902–904, 906–908, 911–912, 914, 961
TOTAL4176684% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 8.700s ⏱️

@kamalq97 kamalq97 added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jan 5, 2026
@kamalq97 kamalq97 marked this pull request as ready for review January 5, 2026 10:03
@content-bot content-bot removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jan 5, 2026
@richardbluestone richardbluestone removed their request for review January 5, 2026 11:07
@content-bot
Copy link
Collaborator

🤖 Content-bot Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Collaborator

@content-bot content-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for the update to the Mimecast pack. I've reviewed the changes and have a few points to discuss, primarily regarding the proxy implementation and test mocking.

Please ensure proxy arguments are passed correctly to the request methods rather than the aiohttp session, and update the unit tests to use AsyncMock for asynchronous methods. It would also be helpful to clarify the API 2.0 credential steps in the documentation and consolidate the breaking changes in the release notes.

Great work so far

@richardbluestone, @JasBeilin please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@richardbluestone
Copy link
Contributor

Hi there! Thanks for the update to the Mimecast pack. I've reviewed the changes and have a few points to discuss, primarily regarding the proxy implementation and test mocking.

Please ensure proxy arguments are passed correctly to the request methods rather than the aiohttp session, and update the unit tests to use AsyncMock for asynchronous methods. It would also be helpful to clarify the API 2.0 credential steps in the documentation and consolidate the breaking changes in the release notes.

Great work so far

@richardbluestone, @JasBeilin please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@julieschwartz18 Can you do this?

Copy link
Contributor

@julieschwartz18 julieschwartz18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamalq97 Doc review complete. Please confirm the suggested edits and regenerate the integration README from the YAML file. In the meantime, adding the label docs-approved.

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: BC112.
The following errors cannot be ignored: BC112.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: BC112.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved enhancement inprogress It means the PR is still on progress, and should not be merged even if the build is green or approve python Pull requests that update Python code ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants