Add barrier between cudaIpcCloseMemHandle and cudaFree in Buffer::destroy#533
Open
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Open
Add barrier between cudaIpcCloseMemHandle and cudaFree in Buffer::destroy#533yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
…troy According to CUDA documentation, it is undefined behavior to cudaFree an exported memory region before cudaIpcCloseMemHandle is called on all processes that opened the handle. This adds a barrier to ensure all ranks have closed their remote IPC handles before any rank frees its local buffer, preventing the race condition where rank A frees its buffer while rank B is still closing the handle to that buffer. Fixes deepseek-ai#497 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
According to CUDA documentation, it is undefined behavior to
cudaFreean exported memory region beforecudaIpcCloseMemHandleis called on all processes that opened the handle.Without this fix, in a multi-GPU scenario:
Test plan
Fixes #497
🤖 Generated with Claude Code