Fix '**kwargs' bug that prevented passing 'max_results' argument to the 'build_payload' function & Allow searching multiple pages if one page is not enough#470
Open
Miss-Tired-Ghost wants to merge 5 commits into
Conversation
…he 'build_payload' function Allow searching multiple pages if one page is not enough Warnings: The '**kwargs' bug appears to affect more than just 'max_results'. This is a bandaid fix and does not address the root problem. The multi-page search uses a while loop which has the potential to cause indefinite freezing if searches fail continuously Due to the calling of the engines multiple times, the chance of encountering the 'DDGSException(err or "No results found.")' error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix '**kwargs' bug that prevented passing 'max_results' argument to the 'build_payload' function
Allow searching multiple pages if one page is not enough
Warnings:
The '**kwargs' bug appears to affect more than just 'max_results'. This is a bandaid fix and does not address the root problem.
The multi-page search uses a while loop which has the potential to cause indefinite freezing if searches fail continuously
Due to the calling of the engines multiple times, the chance of encountering the 'DDGSException(err or "No results found.")' error