Skip to content

setVoteChoices: Missing return on validation error #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jholdstock merged 1 commit into from
Apr 14, 2026
Merged

setVoteChoices: Missing return on validation error #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/webapi/setvotechoices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2020-2024 The Decred developers
// Copyright (c) 2020-2026 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

Expand Down Expand Up @@ -108,13 +108,15 @@ func (w *WebAPI) setVoteChoices(c *gin.Context) {
w.log.Warnf("%s: Invalid treasury policy (clientIP=%s, ticketHash=%s): %v",
funcName, c.ClientIP(), ticket.Hash, err)
w.sendErrorWithMsg(err.Error(), types.ErrInvalidVoteChoices, c)
return
}

err = validTSpendPolicy(request.TSpendPolicy)
if err != nil {
w.log.Warnf("%s: Invalid tspend policy (clientIP=%s, ticketHash=%s): %v",
funcName, c.ClientIP(), ticket.Hash, err)
w.sendErrorWithMsg(err.Error(), types.ErrInvalidVoteChoices, c)
return
}

// Update voting preferences in the database before updating the wallets. DB
Expand Down
Loading