test: integrate precreated CVI into precheck system#2331
Open
hardcoretime wants to merge 2 commits intomainfrom
Open
test: integrate precreated CVI into precheck system#2331hardcoretime wants to merge 2 commits intomainfrom
hardcoretime wants to merge 2 commits intomainfrom
Conversation
universal-itengineer
previously approved these changes
May 7, 2026
The base branch was changed.
- Add PrecheckPrecreatedCVI as common precheck that creates/verifies CVIs - Move image URL constants to precreated_cvi.go for better cohesion - Add IsPrecreatedCVICleanupNeeded field to Config with proper comments - Add precreatedCVI cleanup to SynchronizedAfterSuite (process 1 only) - Remove legacy cleanup functions from config/cleanup.go and legacy.go - Remove unused suite_cvi.go and internal/precreatedcvi package BREAKING CHANGE: PRECREATED_CVI_CLEANUP env var now works with config system Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
e32364a to
ccbc526
Compare
…rnings - Pass context to waitForCVIsReady in precreatedcvi precheck - Propagate context through util functions used by tests Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
ccbc526 to
384b556
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
universal-itengineer
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates precreated ClusterVirtualImages (CVIs) into the precheck system for e2e tests.
Changes:
New precheck implementation (
internal/precheck/precreatedcvi.go):PrecheckPrecreatedCVIas a common precheck that creates/verifies precreated CVIs before testsPRECREATED_CVI_CLEANUPenv variableCleanupPrecreatedCVIs()function for cleanup inSynchronizedAfterSuiteConfig integration:
IsPrecreatedCVICleanupNeededfield toConfigstructPRECREATED_CVI_CLEANUPenv variable with config priority over yamlCode organization:
const.gotoprecreated_cvi.gofor better cohesionconfig/cleanup.goandlegacy/legacy.gosuite_cvi.goandinternal/precreatedcvipackageWhy do we need it, and what problem does it solve?
This refactoring consolidates all precreated CVI handling into the precheck system, making it consistent with other prechecks like
PostCleanupPrecheck.What is the expected result?
PRECREATED_CVI_CLEANUPenv var orisPrecreatedCVICleanupNeededconfig fieldPRECREATED_CVI_CLEANUP=yesto delete CVIs after the suiteChecklist
Changelog entries