feat(windows): taskbar attention overlay badge on bell#516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a taskbar overlay badge that lights up when an unfocused window rings the bell, and clears when the window regains focus. This is the Windows equivalent of
bell-features = attention(which bounces the dock on macOS).Mirrors the existing taskbar progress spine: a pure-logic
TaskbarAttentionCoordinatorin Ghostty.Core writes to a narrowITaskbarOverlaySink; a WinUI facade forwards toITaskbarList3::SetOverlayIcon. The bell flows surface -> PaneHost -> TabManager -> coordinator the same way progress does; window focus drives it fromWindow.Activated. The badge is a small amber dot rasterized at runtime via GDI (no assets, AOT-safe).Ungated, consistent with the taskbar progress indicator.
Tested: unit tests cover the coordinator state machine and the bell forwarding through TabManager. In-app, the badge appears on the taskbar button when a backgrounded window rings the bell, clears when the window is focused, and coexists with the progress bar.