feat(mcp)!: remove norn mcp --read-only (NRN-116)#104
Merged
Conversation
Drop the --read-only flag, its McpArgs field, and the server-side gating (dropping mutation tools from tools/list and refusing them at runtime) that phased in the original MCP build-out (NRN-33). norn mcp now always serves the full 14-tool catalog, matching norn serve, so the two MCP surfaces cannot drift in capability. No external consumer depends on the flag; per-connection capability scoping, if ever wanted, belongs to a future authn/authz layer. Breaking change, no migration shim (pre-1.0).
One review round (engine=code-review, all agents Opus): zero engine findings. One suppression-scan hit — tests/mcp_read_only.rs deleted (13 assertions) — dismissed: the review confirmed every assertion guarded only the removed flag's gating contract; surviving behavior (tools/list shape, audit presence) is pinned elsewhere. Adversarial-Review: run engine=code-review tier=high findings=1 fixed=0 dismissed=1 deferred=0
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
--read-onlyflag fromnorn mcpentirely — the flag, its wiring (McpArgs.read_only→mcp::run/serve→McpServer::new), the runtime mutation-refusal path, its dedicated test suite, and every doc mention. Pre-1.0 breaking change, CHANGELOG'd under### Breaking changes.Decided 2026-07-04 during the NRN-93 design pass (D6): read-only was deliverable-phasing scaffolding from the original MCP build-out, not a feature. No external consumer needs it,
norn servedeliberately ships without it, and per-connection capability scoping — if ever wanted — is the phase-4 authn/authz surface's job. Removing it keeps the two MCP surfaces (stdio + socket) capability-identical so they cannot drift.Nice by-catch: with the refusal gone,
run_mutationwas an identical passthrough and collapsed intorun_wrapped— one less layer on every mutation tool.Verification
check --locked/ 2304 tests, 0 failed (−3 = exactly the deleted flag-only suite) / clippy-D warnings/fmt;Cargo.lockuntouched.Adversarial review
One round (all agents Opus), zero engine findings (1 candidate raised, refuted in verification). One suppression-scan hit — the deleted
tests/mcp_read_only.rs(13 assertions) — dismissed on the record: the review confirmed every assertion guarded only the removed flag's gating contract; surviving behavior (tools/list shape,vault.auditpresence/schema) remains pinned by the kept, renamedmcp_audit.rstests and the parity gate.Adversarial-Review: run engine=code-review tier=high findings=1 fixed=0 dismissed=1 deferred=0