Add linting scripts for phpcbf and prettier in package.json#2
Open
datengraben wants to merge 11 commits into
Open
Add linting scripts for phpcbf and prettier in package.json#2datengraben wants to merge 11 commits into
datengraben wants to merge 11 commits into
Conversation
- Add prettier ^3.0.0 as a devDependency - Add lint:php script running vendor/bin/phpcbf - Add lint:js script running prettier --check on assets JS files - Add lint script combining both lint:php and lint:js https://claude.ai/code/session_01JA2idCjLjHr7dNGMs6CYiv
- Add husky ^9.0.0 and lint-staged ^15.0.0 as devDependencies - Add prepare script to install husky on npm install - Add lint-staged config: phpcbf for *.php, prettier --write for assets JS - Add .husky/pre-commit hook that runs lint-staged before each commit - Document linting setup in Readme.md under Development https://claude.ai/code/session_01JA2idCjLjHr7dNGMs6CYiv
…e-2143 wielebenwir#2143 filter hook for gbfs feed announcement
…e-2156 GBFS: refactor every response to go through same validation function
…ork for uneven amount of days
…or uneven amount of days
wielebenwir#2158 BookingRule::checkMaxBookingDays does not work for uneven amount of days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettier^3.0.0 as a devDependencylint:phpscript that runsvendor/bin/phpcbffor PHP code style fixinglint:jsscript that runsprettier --check 'assets/**/*.js'to verify JS formattinglintscript that combines both checks vianpm run lint:php && npm run lint:jsTest plan
npm installto install the newprettierdevDependencynpm run lint:phpand confirm phpcbf runs against PHP source filesnpm run lint:jsand confirm prettier checks JS files underassets/npm run lintand confirm both checks execute in sequencehttps://claude.ai/code/session_01JA2idCjLjHr7dNGMs6CYiv