CNDB-16269: throw exception and reduce log verbosity when compaction task is rejected#2215
Merged
CNDB-16269: throw exception and reduce log verbosity when compaction task is rejected#2215
Conversation
Checklist before you submit for review
|
|
jasonstack
reviewed
Feb 2, 2026
| } | ||
| else | ||
| assert inProgressReported.get() == progress; // progress object must also be shared | ||
| } |
There was a problem hiding this comment.
would be nice to assert that progress.operationId() matches the parentId in onInProgress
jasonstack
approved these changes
Feb 4, 2026
lesnik2u
force-pushed
the
CNDB-16269
branch
2 times, most recently
from
70ba648 to
7dea9d0
Compare
…n on subtask rejection and prioritize root cause exceptions
|
❌ Build ds-cassandra-pr-gate/PR-2215 rejected by Butler4 regressions found Found 4 new test failures
Found 8 known test failures |
blambov
pushed a commit
that referenced
this pull request
Apr 8, 2026
…task is rejected (#2215) CNDB side - riptano/cndb#16429 Pass parentId explicitly to SharedCompactionObserver instead of deriving it from inProgressReported, fixing error propagation and removing the dependency on onInProgress being called before onCompleted. This pr is a result of this conversation - riptano/cndb#16555 (comment) Refer to this issue riptano/cndb#16269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
CNDB side - https://github.com/riptano/cndb/pull/16429
What does this PR fix and why was it fixed
This pr is a result of this conversation - https://github.com/riptano/cndb/pull/16555#discussion_r2734934442
Refer to this issue https://github.com/riptano/cndb/issues/16269