BF: Migrate CRCNS DataCite fetch to /dois endpoint - #153
Merged
Conversation
DataCite retired the legacy /works REST endpoint (returns 410 Gone with a pointer to /dois, /providers, /clients), which broke test_get_metadata in CI. Switch fetch_datacite_metadata to `/dois?prefix=10.6080&detail=true&page[size]=1000` — prefix 10.6080 is the CRCNS.org DOI namespace, and detail=true is required to include the base64-encoded XML in attributes.xml (list responses omit it by default). Also swap base64.decodestring for base64.b64decode (the former was removed in Python 3.9) and update the outdated search.datacite.org host check in the skip-on-502 fallback to api.datacite.org so the test still skips gracefully on transient upstream errors. Co-Authored-By: Claude Code 2.1.202 / Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 76.58% 76.94% +0.35%
==========================================
Files 58 58
Lines 4733 4733
Branches 596 596
==========================================
+ Hits 3625 3642 +17
+ Misses 947 928 -19
- Partials 161 163 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataCite retired the legacy /works REST endpoint (returns 410 Gone with a pointer to /dois, /providers, /clients), which broke test_get_metadata in CI. Switch fetch_datacite_metadata to
/dois?prefix=10.6080&detail=true&page[size]=1000— prefix 10.6080 is the CRCNS.org DOI namespace, and detail=true is required to include the base64-encoded XML in attributes.xml (list responses omit it by default).Also swap base64.decodestring for base64.b64decode (the former was removed in Python 3.9) and update the outdated search.datacite.org host check in the skip-on-502 fallback to api.datacite.org so the test still skips gracefully on transient upstream errors.