Address deprecation warnings - #499
Open
yarikoptic wants to merge 2 commits into
Open
Conversation
`jsonschema.RefResolver` is deprecated as of jsonschema 4.18.0 in favor of the `referencing` library, and merely importing it now triggers a DeprecationWarning that fails test collection under strict warning filters (e.g. datalad-extensions CI). Switch all three usage sites (webcatalog, validate, test_schema) to build a `referencing.Registry` from the schema store and pass it to `Draft202012Validator(..., registry=...)`. `Resource.from_contents()` infers the dialect from each schema's `$schema` field. Bump the `jsonschema` requirement to `>= 4.18.0` since the `registry=` kwarg only exists from that release; `referencing` ships as a transitive dependency from the same version, so no explicit `referencing` requirement is needed. Co-Authored-By: Claude Code 2.1.140 / Claude Opus 4.7 <noreply@anthropic.com>
✅ Deploy Preview for datalad-catalog canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FWIW&Disclaimer: some done with claude code assistance. I do not see any unique expression of anyone, so I do not think these changes could be claimed by anyone to be copyrightable if that matters.