JiT compilation support in JS API#2086
Merged
ikholopov-omni merged 1 commit intodataform-co:mainfrom Feb 11, 2026
Merged
Conversation
ikholopov-omni
requested review from
Tuseeq1 and
kolina
and removed request for
a team
This was referenced Feb 10, 2026
kolina
approved these changes
Feb 10, 2026
core/actions/incremental_table.ts
Outdated
| flattenPreOps = flattenPreOps.concat(typeof op === "object" ? op : [op]); | ||
| }) | ||
| if (!!this.contextableQuery || !!this.contextableWhere || !!flattenPostOps.length || !!flattenPreOps.length) { | ||
| const err = new Error(`Cannot mix AoT and JiT compilation in action: ${this.contextableQuery}, ${this.contextableWhere}, ${this.contextablePostOps}, ${this.contextablePreOps}`); |
Contributor
There was a problem hiding this comment.
I'd report specific violation reason here (i.e. what specific config field triggered it)
| */ | ||
| export class TableContext implements ITableContext { | ||
| constructor(private table: Table, private isIncremental = false) {} | ||
| constructor(private table: Table, private isIncremental = false) { } |
Contributor
There was a problem hiding this comment.
what is the cause of these diffs?
Collaborator
Author
There was a problem hiding this comment.
My IDE (vscode) is extremely opinionated about TS formatiing, apparently (like golang-level of opinionation).
I could clean those up by splitting it out of the commit, but this will continue being an overhead long-term :/
Probably worth setting up formatter next to the linter check.
core/actions/table.ts
Outdated
Comment on lines
524
to
536
| let flattenPostOps: unknown[] = []; | ||
| this.contextablePostOps.forEach(op => { | ||
| flattenPostOps = flattenPostOps.concat(typeof op === "object" ? op : [op]); | ||
| }) | ||
| let flattenPreOps: unknown[] = []; | ||
| this.contextablePreOps.forEach(op => { | ||
| flattenPreOps = flattenPreOps.concat(typeof op === "object" ? op : [op]); | ||
| }) | ||
| if (!!this.contextableQuery || !!this.contextableWhere || !!flattenPostOps.length || !!flattenPreOps.length) { | ||
| const err = new Error(`Cannot mix AoT and JiT compilation in action: ${this.contextableQuery}, ${this.contextableWhere}, ${this.contextablePostOps}, ${this.contextablePreOps}`); | ||
| this.session.compileError(err, this.getFileName()); | ||
| throw err; | ||
| } |
Contributor
There was a problem hiding this comment.
This validation can be reused for different action types?
Collaborator
Author
There was a problem hiding this comment.
Moved to util
ikholopov-omni
force-pushed
the
jit-js-compile
branch
from
d07fdb1 to
d30d6c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS API for JiT compilation actions definition (mutually exclusive with AoT properties) and JiT context/result typings.