feat: change output if all diff output is suppressed#768
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new change style ("MODIFY_SUPPRESSED") to improve the clarity of diff output when all changes are suppressed. It updates the report generation across various output formats and tests for the new suppressed diff output.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| diff/report.go | Adds a new ChangeStyle for "MODIFY_SUPPRESSED" with a descriptive message in diff and simple reports. Updates JSON and template reports with an empty message. |
| diff/diff_test.go | Updates tests to expect the new "MODIFY_SUPPRESSED" message when diffs are suppressed. |
| diff/diff.go | Modifies diff suppression logic to assign the "MODIFY_SUPPRESSED" change type when applicable. |
|
did you test it locally? |
I did add a unit test. |
this is better. |
|
or we can use new var? |
bd45ab8 to
8883fb5
Compare
|
I have changed the code. How about this variant: |
we can try this. |
|
@yxxhero I have simplified the code even more using switch/case. Also I fixed the the color to be actually used and chose a color that actually exists in the lib. |
|
@mumoshu WDYT? |
If a diff exists but is suppressed in the output change the text to make it more clear what is actually happening.