Migrate base interfaces to statistical_comparison_core and statistical_comparison_helpers - #2
Open
HarukiNishimura-TRI wants to merge 3 commits into
Open
Conversation
…l_comparison_helpers - Base hypothesis testing enums/classes are imported from the new statistical_comparison_core instead of sequentialized_barnard_tests - Remove redundante plotting and CLD code from this package; they are migrated to statistical_comparison_helpers - Add statistical-comparison-core and statistical-comparison-helpers as new dependencies. Also add cvxpy. - Update setup.py - Update tools/plotting.py deprecation shims
There was a problem hiding this comment.
Pull request overview
This PR migrates nscore’s core hypothesis-testing interfaces and plotting/CLD utilities to the external statistical_comparison_core and statistical_comparison_helpers packages, keeping backward compatibility via deprecation shims while updating packaging metadata and tests accordingly.
Changes:
- Replace imports of base testing types (e.g.,
Decision,Hypothesis, mixins/base classes) to come fromstatistical_comparison_core. - Convert plotting/CLD helpers in
nscore.tools.plottinginto deprecation shims delegating tostatistical_comparison_helpers, and add focused tests for those shims. - Update packaging (
setup.py) dependencies and add a project.gitignore.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_nscore_deprecation_shims.py |
Adds tests validating deprecation warnings and behavior parity for plotting/CLD shims. |
tests/methods/test_continuous_nsm.py |
Updates test imports to use statistical_comparison_core types. |
tests/methods/test_binary_nsm.py |
Updates test imports to use statistical_comparison_core types. |
setup.py |
Updates runtime dependencies to include the new core/helper packages (and cvxpy) and simplifies setup config. |
nscore/wsr.py |
Switches base interface imports to statistical_comparison_core and updates docstring. |
nscore/utils/utils_wsr.py |
Updates module docstring to reflect nscore namespace. |
nscore/tools/plotting.py |
Replaces local implementations with deprecation shims delegating to statistical_comparison_helpers. |
nscore/savi.py |
Switches base interface imports to statistical_comparison_core. |
nscore/nsm.py |
Switches base interface imports to statistical_comparison_core. |
nscore/nonparametric_nsm.py |
Switches base interface imports to statistical_comparison_core. |
nscore/batch.py |
Removes sequentialized_barnard_tests dependency usage and switches base interface imports to statistical_comparison_core. |
.gitignore |
Adds common Python build/test artifacts to gitignore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
HarukiNishimura-TRI
requested review from
dasnyder5
and removed request for
das-penn
July 3, 2026 02:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate base interfaces to statistical_comparison_core and statistical_comparison_helpers
This closes #1