Skip to content

fix(gtk): amend build against X11-enabled GTK #20034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TurboGit merged 1 commit into from
Dec 30, 2025
Merged

fix(gtk): amend build against X11-enabled GTK #20034

TurboGit merged 1 commit into from
Dec 30, 2025

Conversation

@yuri1969
Copy link
Contributor

@yuri1969 yuri1969 commented Dec 30, 2025

Build of 5.4.0 was failing at X11-based Gentoo with:

darktable-5.4.0/src/gui/gtk.c:998:43: error: ‘GDK_TYPE_X11_DISPLAY’ undeclared (first use in this function); did you mean ‘GDK_TYPE_DISPLAY’?                                                                       
  998 |   return G_TYPE_CHECK_INSTANCE_TYPE(disp, GDK_TYPE_X11_DISPLAY)
      |                                           ^~~~~~~~~~~~~~~~~~~~

This patch fixed the build.

  • Build failed at missing GDK_TYPE_X11_DISPLAY
  • Corrected a typo

@yuri1969
fix(gtk): amend build against X11-enabled GTK
da91b66 
* Build failed at missing `GDK_TYPE_X11_DISPLAY`
* Corrected a typo
@ralfbrown ralfbrown added bugfix pull request fixing a bug scope: UI user interface and interactions labels Dec 30, 2025
@TurboGit TurboGit added this to the 5.4.1 milestone Dec 30, 2025
@TurboGit TurboGit added the priority: high core features are broken and not usable at all, software crashes label Dec 30, 2025
TurboGit
TurboGit approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 2f5ae73 into darktable-org:master Dec 30, 2025
4 of 5 checks passed
@yuri1969 yuri1969 deleted the fix-gtk-x11 branch December 30, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees

No one assigned

Labels

bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: UI user interface and interactions

Projects

None yet

Milestone

5.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@yuri1969 @TurboGit @ralfbrown