Skip to content

Make Twitter enable no title #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ytripet wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make Twitter enable no title #56

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f72634f
change lthat if data attribut is there not use default in ttitle
ytripet Oct 28, 2016
709620b
change lthat if data attribut is there not use default in ttitle
ytripet Oct 28, 2016
cd8e5b5
improvments
Nov 3, 2016
1d34c7a
remove title on email body
ytripet Nov 9, 2016
8c801c3
Merge branch 'master' of https://github.com/soundintheory/social-shar…
ytripet Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dist/js/social-share-kit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ var SocialShareKit = (function () {
};
switch (network) {
case 'facebook':
url = 'https://www.facebook.com/share.php?u=' + paramsObj.shareUrlEncoded();
url = 'https://www.facebook.com/share.php?u=' + paramsObj.shareUrlEncoded() + (!!paramsObj.text ? '&quote=' + encodeURIComponent(paramsObj.text.replace(/\n/g, ' ... ')) : '');
break;
case 'twitter':
url = 'https://twitter.com/intent/tweet?url=' + paramsObj.shareUrlEncoded() +
Expand Down Expand Up @@ -230,8 +230,12 @@ var SocialShareKit = (function () {
url = 'https://vkontakte.ru/share.php?url=' + paramsObj.shareUrlEncoded();
break;
case 'email':
url = 'mailto:?subject=' + encodeURIComponent(title) +
'&body=' + encodeURIComponent(title + '\n' + shareUrl + '\n\n' + text + '\n');
url = 'mailto:?subject=' + encodeURIComponent(title?title:document.title) +
'&body=' + encodeURIComponent(
(!!title ? title + '\n' : '') +
(!!shareUrl ? shareUrl + '\n\n' : '') +
(!!text ? text + '\n' : '')
);
break;
}

Expand All @@ -246,6 +250,7 @@ var SocialShareKit = (function () {

function getShareUrl(options, network, el, dataOpts) {
dataOpts = dataOpts || getDataOpts(options, network, el);
if (dataOpts['url'] === '') { return ''; }
return dataOpts['url'] || window.location.href;
}

Expand Down Expand Up @@ -283,6 +288,9 @@ var SocialShareKit = (function () {
if (typeof optValue != 'undefined') {
opts[optKey] = optValue;
}
else if(el.hasAttribute(dataKey)){
opts[optKey] = "";
}
}
return opts;
}
Expand Down