Skip to content

DAN-49 - Route map add match by local-preference #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbs2web wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DAN-49 - Route map add match by local-preference #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d515a1
Add matching by local-preference
bbs2web Jan 16, 2020
f1e1694
Allow setting preferred source
bbs2web Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions yang/vyatta-policy-route-v1.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,13 @@ module vyatta-policy-route-v1 {
description "IS-IS level";
configd:help "IS-IS level";
}
leaf src {

@deastoe deastoe Mar 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think source would be better as it is not much longer and is consistent with other nodes in this module (eg. access lists).

type union {

@deastoe deastoe Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing type definition for this in vyatta-types-v1-yang. The advantage of the existing type is that it also ensures values are normalized into a canonical form.

vyatta-types-v1 is already imported, so you can use the type like so:

type types:ip-address;

type types:ipv4-address;
type types:ipv6-address;
}
configd:help "Preferred source address";

@deastoe deastoe Mar 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a description statement, you can re-use the text eg.

description "Preferred source address";

}
}
leaf continue {
type uint32 {
Expand Down Expand Up @@ -1049,6 +1056,10 @@ module vyatta-policy-route-v1 {
configd:help "Source protocol to be matched";
}
}
leaf local-preference {
type uint32;
configd:help "Border Gateway Protocol (BGP) local preference attribute";

@deastoe deastoe Mar 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a description statement.

}
leaf origin {
type enumeration {
enum "egp" {
Expand Down