Fix variable name in CoberturaParser#780
Merged
danielpalme merged 2 commits intodanielpalme:mainfrom Mar 31, 2026
Merged
Conversation
Fix variable name for GetBranches method
Owner
|
I had to make some adjustments in your code changes in order to compile. For most Cobertura files the change will not make any difference. Because the line elements appear twice in the XML report (Example). There was an issue (#603) for files generated by Jest. Here some lines did only appear once. Now all elements are also used to determine branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, branches are only determined from lines outside of methods which doesn't seem to make much sense as that number is usually zero. With this tiny fix, all lines are considered for branch coverage.