fix(cmd): preserve spaced dash params#2276
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR fixes parameter parsing when quoted strings with spaces are passed after the ChangesParameter quoting for dash-separated arguments
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Looking great! Thanks a lot for fixing the bug. |
yohamta0
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows for params after "--" to contain space char.
Changes
Related Issues
Closes #2275
Checklist
Summary by cubic
Preserves spaces in params passed after
--indagu start, and lets a single JSON arg pass through unchanged. Prevents splitting values like "Something here" and keeps JSON objects/arrays valid.quoteStartDashArgswhen buildingDashArgsandspec.WithParamsto quote spaced values but skip quoting for a single JSON arg.paramsstring from joined dash args for correct display.--and for a single JSON param after--.Written for commit 4c08842. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
--separator. Arguments containing spaces are now correctly preserved as single values and properly mapped to their target parameters.Tests
--separator.