For discussion: Monster Popup Feature + Message code opt&cleanup

[jeffsenn]

Adds a "Popup Image to Players" button next to "send to gamelog" for monster images.

This uses magnific to popup the image directly to players for 10 seconds. (As if it was sent to gamelog and then clicked on in the gamelog).

I added this primarily for use at my game live table - where I just want to quickly pop an image but not have to do a lot of interaction to do so.

Note: also adds else's to message handling to optimize in MessageBroker

[Azmoria]

Got to playing with this, I agree that it's nice to be able to quick show. I wonder if there's a case for a button for closing the image too (for people using a tabletop or projector) similar to notes.

Minor issue, needs some css adjustment to make sure text is always in the buttons on that row. It might only affect official monsters since they have 3 buttons now. Maybe height: fit-content or something like that.

We already discussed and agreed it'd be nice to have the button where other send to buttons are, and individual whispers like you mention. We can do some of this in chunks, we don't need all the buttons available right away.

One other comment for consideration, it'd be nice to get it working for video tokens too. It's still magnific, some are auto detected based on file extension other are if the token has the video token flag.

Example of video popup and it not being setup for this yet
https://github.com/user-attachments/assets/cfae7388-d522-4515-9df9-0c1949825960

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[jeffsenn]

Example of video popup and it not being setup for this yet
https://github.com/user-attachments/assets/cfae7388-d522-4515-9df9-0c1949825960

@Azmoria - what was that example? Is that a video as a link or image embed? (it's not an embedded video, right?)

[Azmoria]

On the token? It's just a video file attached to the token like any image link. In this case it was this

https://dl.dropboxusercontent.com/scl/fi/cqkr786hmgr8wfc8syt87/Moonbeam.webm?rlkey=kryl7v4uxnwv20r46v3kvrc52&dl=0

This is the code that does the popout. which does use an iframe, if that was the question. We use an extension html page to embed the video in since DDB made some security changes awhile back breaking magnific's default settings for video.

The one in chat and on the token are just <video> elements though

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request soon-ish