Skip to content

Conversation

@evman182
Copy link

@evman182 evman182 commented Dec 10, 2025

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

"execa": "4.1.0",
"istanbul-lib-coverage": "^3.0.0",
"js-yaml": "4.1.0",
"js-yaml": "4.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also make this more future-proof? Not sure why we have ^ versioning for some but not all dependencies.

Suggested change
"js-yaml": "4.1.1",
"js-yaml": "^4.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking into account the recent amount of npm supply chain vulnerabilities where unsolicited (and vulnerable) patch versions caused drastic mayhem, I would highly recommend the opposite — switching to strict dependency package versioning.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fyodorio
I think using strict package version is a good way.
But it requires more timely maintenance to upgrade the dependency versions.

This vulnerability issue was reported at Nov 13, 2025
But the dependency upgrade is still in progress for now (almost 3 months).

@jlocke2
Copy link

jlocke2 commented Jan 20, 2026

@jpage-godaddy @AtofStryker @jennifer-shehane - Apologies for the ping (not sure who the right person would be in this case), but would it be possible to review/merge this change as it relates to GHSA-mh29-5h37-fv8m. Happy to help if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security vulnerability: Update js-yaml from 4.1.0 to 4.1.1 to fix prototype pollution (BDSA-2025-27523)

7 participants