-
Notifications
You must be signed in to change notification settings - Fork 112
Update js-yaml to 4.1.1 #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
| "execa": "4.1.0", | ||
| "istanbul-lib-coverage": "^3.0.0", | ||
| "js-yaml": "4.1.0", | ||
| "js-yaml": "4.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also make this more future-proof? Not sure why we have ^ versioning for some but not all dependencies.
| "js-yaml": "4.1.1", | |
| "js-yaml": "^4.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking into account the recent amount of npm supply chain vulnerabilities where unsolicited (and vulnerable) patch versions caused drastic mayhem, I would highly recommend the opposite — switching to strict dependency package versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fyodorio
I think using strict package version is a good way.
But it requires more timely maintenance to upgrade the dependency versions.
This vulnerability issue was reported at Nov 13, 2025
But the dependency upgrade is still in progress for now (almost 3 months).
|
@jpage-godaddy @AtofStryker @jennifer-shehane - Apologies for the ping (not sure who the right person would be in this case), but would it be possible to review/merge this change as it relates to GHSA-mh29-5h37-fv8m. Happy to help if needed. |
GHSA-mh29-5h37-fv8m
fixes: #970