standardise user name interface#7245
Open
oliver-sanders wants to merge 2 commits intocylc:masterfrom
Open
Conversation
* Residual remains of the Cylc 7 remrun interface.
* Replace `pwd.getpwnam().pw_name` with `getpass.getuser()`. * Closes cylc#7240 * This ensures consistency with other parts of Cylc which are already using the `getpass` interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote: remove unused remote_user interface:
remote: standardise user name interface
pwd.getpwnam().pw_namewithgetpass.getuser().using the
getpassinterface.This is targetting 8.7.0 as the change was judged a little risky for a bugfix release.
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.