Skip to content

Improve file operation permissions and path resolution logic #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
udirctera merged 7 commits into from
Jan 27, 2026
Merged

Improve file operation permissions and path resolution logic #332

udirctera merged 7 commits into from
Jan 27, 2026

Conversation

@udirctera
Copy link
Collaborator

@udirctera udirctera commented Jan 25, 2026 

### Description

This pull request introduces enhancements to the permission handling and path resolution logic in core commands. Key updates include:

- Refined permission error detection and adjusted path resolution to handle various root cases.
- Improved response handling for task completions with warnings.
- Added a `strict_permission` flag to core file operation methods, enabling optional strict permission validation for actions like copy, move, upload, delete, and rename.

### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

### How Has This Been Tested?

_Explain how these changes have been tested._

@udirctera
PIM-6080
05a5ac2 
Add `strict_permission` flag to core file operations

This commit introduces an optional `strict_permission` parameter to multiple file operation methods, which enables enhanced permission validation before executing actions like copy, move, upload, delete, and rename.
@udirctera
PIM-6080
9477c7c 
Improve permission handling and path resolution logic in core commands

This update refines permission error detection, adjusts path resolution to accommodate additional root cases, and improves response handling for task completion with warnings.
asafn-ctera
asafn-ctera reviewed Jan 26, 2026
View reviewed changes
asafn-ctera
asafn-ctera reviewed Jan 26, 2026
View reviewed changes
asafn-ctera
asafn-ctera reviewed Jan 26, 2026
View reviewed changes
@udirctera
PIM-6080
14141a8 
Refactor strict permission error handling

This commit streamlines strict permission error detection by introducing helper functions for normalizing responses and mapping errors, improving maintainability and readability of the code.
@udirctera
PIM-6080
1ca6ec7 
Extend permission error mapping and refactor strict permission handling logic

This commit adds a comprehensive task error mapping for strict permission validation, introduces a helper function for extracting task error details, and updates logging for improved debugging.
@udirctera
PIM-6080
abf9b80 
Remove unused `_is_permission_denied_message` function from core commands
@udirctera
PIM-6080
fc60395 
Simplify strict permission error handling by replacing error maps with sets.
@udirctera
PIM-6080
711b78d 
Add unit tests for strict permission handling in `move` and `mkdir` operations
@udirctera udirctera merged commit 52fd216 into master Jan 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asafn-ctera asafn-ctera asafn-ctera left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@udirctera @asafn-ctera