Open
Conversation
Specification pattern to have filters coming from domain; Visitor pattern to visit expression based filters specificially for EF; Combo filters using expression trees; Lesson has internal id visible to infrastructure domain only; LessonEntity tags and authors changed to string to ease storing in database collection; CSInnDbContext with initial table- lessons.
Using ExpressionVisitor to unify parameter from both composite expression sides; Expressions-based stuff moved to Repository.Infrastructure; Expressions-based stuff made internal; OrElse, Not composite expressions.
UnitOfWork to encapsulate repositories with lazy loading and shared transaction; Solution file location adjustment; Generic repository interface for async.
|
@Almantask Once you have updated the PR with the most recent code and fix the Codacy PR Quality issues, I will take another look at this PR. If this PR is inactive for 2 more weeks I will close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification pattern for filtering lessons (or other entities). This involves composite pattern to build expressions for specification, visitor pattern for applying domain specification to EF format (expression). Filters support And, Or, Not. Specification works for in-memory stuff (IsSatisfiedByItem) and for EF.
Usability: in lesson search page we will have something like discord:
a) on every filter applied, a specification will be created. Later specifications will be joined and sent as one to repo
b) a string query will be created, which will be passed to another specification, which will act as string query parser, which will be sent to repo